Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clip drag past edge of Timeline (without resetting position) #5621

Merged
merged 17 commits into from
Oct 4, 2024

Conversation

jonoomph
Copy link
Member

Remove Droppable Track from Angular timeline code. Replace with static function called on Draggable End (to update UI data). Allows for clips to be dragged to edge of timeline without resetting back to original positions. Also fixed a race condition (on Web Engine) that caused a ng-click to happen after a drag (randomly) clearing selections.

…c function called on Draggable End (to update UI data). Allows for clips to be dragged to edge of timeline without resetting back to original positions. Also fixed a race condition (on Web Engine) that caused a ng-click to happen after a drag (randomly) clearing selections.
…side the timeline without interrupting the drag operation).
… the beginning of the timeline (moves the playhead and scrolls)
…ut. Adding a new double click to reveal the entire timeline. Resizable tracks (right edge) to adjust project duration. Fixed cursor over timeline ruler time values.
…sed the current selection position to jump on mouse release
… near the left/right edge, it would shrink the zoom selection (i.e. zoom in unexpectedly)
…d from playhead line. Also, added a new snap target for end of timeline.
…right edge aligned to the right (not center). Also, don't center unless zoomIn and zoomOut are used - all other zoomSlider functions should not try and center on playhead (it causes flickering)
…reen, when zooming in, and don't allow timeline to be middle-button panned away from the edge. This prevents the playhead from detaching, and keeps the UI stable when zooming into the far right edge of the timeline.
…usts the end frame to include all frames, even ones that extend past the final clip. Also added this to the documentation, and updated the translation POT.
… use the last entered settings. It is saved/loaded in a project. Also adding a "Restore Defaults" button to reset the export dialog.
… a similar "Start at first Clip" option. Removed internal QLineEdits from save_settings (i.e. children of spinners)
@jonoomph jonoomph merged commit 00c3cb4 into develop Oct 4, 2024
9 checks passed
@jonoomph jonoomph deleted the drag-off-timeline branch October 4, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant